Skip to content

ESP32 RMT High-priority Interrupt driver (PRv2)#4799

Closed
willmmiles wants to merge 4 commits intowled:mainfrom
willmmiles:esp32-rmt-hi
Closed

ESP32 RMT High-priority Interrupt driver (PRv2)#4799
willmmiles wants to merge 4 commits intowled:mainfrom
willmmiles:esp32-rmt-hi

Conversation

@willmmiles
Copy link
Member

@willmmiles willmmiles commented Jul 31, 2025

Temporarily switch to a NeoPixelBus fork with a custom high-priority interrupt based driver for using the RMT hardware on ESP32 platforms. This driver is currently draft PR'd upstream at Makuna/NeoPixelBus/pull/892. Fixes #4389 and related issues.

Currently I've tested ESP32 (IDF v3 and v4), ESP32-S2, and ESP32-S3; it works well for me. Further testing would be very helpful!

ESP32-C3 support is still pending as it will require a different IRQ shim layer.

I'm opening this draft to provide a link to builds with the current WIP version.

Replaces #4797, without the unfinished and superfluous changes for making custom ESP-IDF builds.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 31, 2025 •
edited
Loading

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@willmmiles
Copy link
Member Author

willmmiles commented Aug 1, 2025 •
edited
Loading

C3 support is up and seems to work OK on my first test board, though I did see one WDT reboot. I haven't been able to cause another one though. :(

@DedeHai
Copy link
Collaborator

DedeHai commented Aug 1, 2025

I can test on C3 and S2 this weekend

@DedeHai
Copy link
Collaborator

DedeHai commented Aug 2, 2025

Tested on S2 and C3 and did not see any flickering nor crashes when heavily browsing the UI.

@willmmiles
Copy link
Member Author

willmmiles commented Aug 12, 2025

Testing notes: I made a 0_15_x build for C3 with this patch and #4796 with the intent of testing #4347 and unfortunately it IWDT crashed fairly quickly under load from HA; just #4796 has lasted a couple days already. Either there's some other bug that's corrupting memory (#4808-type races maybe, though HA was just reading?) or there's still some issue with the C3 implementation here. I am continuing to test.

@github-actions
Copy link

github-actions bot commented Dec 11, 2025

Hey! This pull request has been open for quite some time without any new comments now. It will be closed automatically in a week if no further activity occurs.
Thank you for contributing to WLED! ❤️

@github-actions github-actions bot added the stale This issue will be closed soon because of prolonged inactivity label Dec 11, 2025
@willmmiles willmmiles closed this Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

stale This issue will be closed soon because of prolonged inactivity

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

LED data corruption with RMT driver

2 participants

@willmmiles @DedeHai